Fix two issues with profiles

[dgageot]

Fix #3277
Fix #3261

[codecov]

Codecov Report

Merging #3278 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files	Coverage Δ
pkg/skaffold/config/options.go	100% <100%> (ø)	⬆️
pkg/skaffold/schema/profiles.go	88.63% <100%> (+0.06%)	⬆️

[petr-buchin]

@dgageot Thank you very much for a fix of my issue!
However, what do you think - maybe it's better to create some hash of profiles string, instead of trimming it to 62 characters and adding z ?

Hash from the whole profiles string will actually change with the profiles string, but trimmed string will not, if changes were made after "trim point".

[dgageot]

Well, you're right, I was a bit "lazy" on this one ;-)
I'm not sure I like the solution with a digest, it's not something users can really decipher.

• We could add one label per profile (profile.1=..., profile2=...)
• Or we could remove that altogether. I'm not sure it brings a lot of value.

@balopat wdyt?

[dgageot]

OK, I decided to replace my ugly hack and use a key per profile instead.
(It doesn't run any check on profile names, though)

[balopat]

LGTM. I do think there is value in the profile.0, profile.1, ... label schema - it shows the order of the application for the profiles, which matters. Regarding the 63 character validation: I think that's a low probability enough issue + validation now will fail with a meaningful error message as the label validation will be exactly on the profile name.