Clarify GCP service account and secret creation #3488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got tripped up on the name of the secret (my key name was incorrect). This might help
wstrange
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
|
Looking further into the gcpBucket - it is not clear to me that skaffold even uses this feature. It seems to ignore it and upload directly to the pod. Are the docs wrong? |
dgageot
approved these changes
Jan 15, 2020
dgageot
suggested changes
Jan 15, 2020
|
@wstrange I'll merge and submit another PR to remove that |
dgageot
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got tripped up on the name of the secret (my key name was incorrect). This might help