Auto sync with Buildpacks #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
Codecov Report
|
dgageot
force-pushed
the
bp-sync
branch
3 times, most recently
from
70e3c96
to
b599f96
Compare
Signed-off-by: David Gageot <[email protected]>
balopat
reviewed
Jan 26, 2020
balopat
reviewed
Jan 27, 2020
| @@ -70,13 +71,17 @@ func GetRunContext(opts config.SkaffoldOptions, cfg latest.Pipeline) (*RunContex | |||
| insecureRegistries[r] = true | |||
| } | |||
|
|
|||
| // TODO(dgageot): what about debug? | |||
There was a problem hiding this comment.
currently debug does not do sync. Also during debugging not sure how the restart would impact the session - I guess they would reconnect...but my gut feeling is that we can safely ignore this for now for debug.
There was a problem hiding this comment.
Thanks, I'll remove the comment!
balopat
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds automatic sync configuration for buildpacks.
Buildpacks can set special metadata on the image to indicate which files need to be synced.
More work is needed on this feature but I'd like this first step to be reviewed and merged.
Signed-off-by: David Gageot [email protected]