Better detection of terminals. #3611
Conversation
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
Will disable docker progress bars and buildpack’s coloured output in VSCode. Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
better-output
branch
from
ae521da to
03d5deb
Compare
Codecov Report
|
| io.Writer | ||
| } | ||
|
|
||
| // If out is not a terminal, let's make sure pack doesn't output with colors |
There was a problem hiding this comment.
Huh, I've never seen coloured output from pack!
| @@ -103,12 +102,8 @@ func isTerminal(w io.Writer) bool { | |||
| return true | |||
There was a problem hiding this comment.
Is the function comment still current? Or could we just replace isTerminal with a direct call to IsTerminal()?
There was a problem hiding this comment.
I'm removing the comment. The test on ColoredWriteCloser is needed here
| "strings" | ||
|
|
||
| "golang.org/x/crypto/ssh/terminal" | ||
| "github.com/GoogleContainerTools/skaffold/pkg/skaffold/util" |
There was a problem hiding this comment.
Would it be worth rewritting this code to use heroku/color at some point?
There was a problem hiding this comment.
It's somewhere on my TODO...
|
|
||
| // If out is not a terminal, let's make sure pack doesn't output with colors | ||
| if _, isTerm := util.IsTerminal(out); !isTerm { | ||
| color.Disable(true) |
There was a problem hiding this comment.
I'm guessing that pack uses heroku/color under the hood? Would be worth a comment here?
Signed-off-by: David Gageot <[email protected]>
Will disable docker progress bars and buildpack’s coloured output in VSCode.
cc @jonjohnsonjr
Signed-off-by: David Gageot [email protected]