Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestWaitForPodSucceeded flake #3818

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Fix TestWaitForPodSucceeded flake #3818

merged 1 commit into from
Mar 13, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 11, 2020

  • Increase the timeout
  • Better error message

Signed-off-by: David Gageot [email protected]

@dgageot
Fix TestWaitForPodSucceeded flake
b71778c 
+ Increase the timeout
+ Better error message

Signed-off-by: David Gageot <[email protected]>
@codecov
Copy link

codecov bot commented Mar 11, 2020 •
edited
Loading

Codecov Report

Merging #3818 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/kubernetes/wait.go 45.83% <100%> (ø) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@dgageot dgageot merged commit 6be2fdf into GoogleContainerTools:master Mar 13, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 20, 2020
Merged
@dgageot dgageot mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @tejal29 @googlebot