Whitelist recursively transformable kinds. #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refers to issue GoogleContainerTools#1737. Previously FieldVisitors (image/namespace collector/transformer, labelsSetter) are applied to all fields of all resources recursively except for CRDs which were known to break otherwise since their schema contains a "metadata" property as well. However other unknown kinds / CRs may contain such properties as well and break. This PR whitelists the known kinds that can be transformed recursively instead of attempting to blacklist kinds that cannot. Signed-off-by: Max Goltzsche <[email protected]>
mgoltzsche
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
dgageot
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers to/fixes #1737, particularly to this comment.
Previously (PR) FieldVisitors (image/namespace collector/transformer, labelsSetter) are applied to all fields of all resources recursively except for CRDs which were known to break otherwise since their schema contains a "metadata" property as well.
However other unknown kinds / CRs may contain such properties as well and break.
This PR whitelists the known kinds that can be transformed recursively instead of attempting to blacklist kinds that cannot be.
User facing changes
Applying a CR that contains a "metadata" or "image" field within the spec will work. (Previously skaffold destroyed the CR.)
Resource label and image modifications are only applied recursively on the fields of a known workload kind: Pod, ReplicaSet, StatefulSet, Deployment, DaemonSet, Job, CronJob.