-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skaffold render --output takes GCS file path #3979
Conversation
Codecov Report
|
Hi @ChrisGe4, I'm a bit reluctant in merging such feature that avoids piping into gsutil. Can you tell us more about why you need this feature? |
Hi @dgageot, we are interested in using Skaffold in a new project. One step in the workflow is uploading the hydrated manifests to a GCS bucket. |
@ChrisGe4 ok. I'm still a bit reluctant since it looks like we could just pipe the output of skaffold to gsutil. But let's move on! I added a few comments. |
pull from upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM also with two tiny nits
@ChrisGe4 looks like you actually have one small linter error, can you check that out? not sure what happened with the kokoro job but it looks like it got stuck so I restarted it. when CI is green I'll merge |
Fixes: #3902
Description
This PR adds gsutil.go that calls 'gsutil' to copy rendered manifests to a GCS bucket when skaffold render --output takes a file path starts with gs://