Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing test config invalidates the build cache #3984

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Changing test config invalidates the build cache #3984

merged 1 commit into from
Apr 21, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 20, 2020

Fixes #3982

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Apr 20, 2020 •
edited
Loading

Codecov Report

Merging #3984 into master will decrease coverage by 0.05%.
The diff coverage is 22.22%.

Impacted Files Coverage Δ
pkg/skaffold/runner/new.go 69.79% <22.22%> (-2.93%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️

@tejal29
Copy link
Member

tejal29 commented Apr 21, 2020

The build failed due to OOO. Restarted the build.
the PR looks good to me.

@dgageot dgageot merged commit 07993d1 into GoogleContainerTools:master Apr 21, 2020
@fmotrifork fmotrifork mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@briandealwis briandealwis Awaiting requested review from briandealwis

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

@TadCordle TadCordle Awaiting requested review from TadCordle

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing test config should invalidate the build cache
3 participants
@dgageot @tejal29 @googlebot