Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default-repo handling for skaffold deploy #4074

Merged
merged 1 commit into from
May 4, 2020
Merged

Fix default-repo handling for skaffold deploy #4074

merged 1 commit into from
May 4, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 30, 2020

Fix #3765

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Apr 30, 2020 •
edited
Loading

Codecov Report

Merging #4074 into master will decrease coverage by 0.04%.
The diff coverage is 26.31%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 69.44% <0.00%> (-11.21%) ⬇️
pkg/skaffold/runner/runner.go 0.00% <ø> (ø)
pkg/skaffold/runner/build_deploy.go 57.29% <35.71%> (-0.32%) ⬇️

@dgageot dgageot force-pushed the fix-3765 branch 2 times, most recently from d99f87f to 3293cb3 Compare April 30, 2020 14:36
balopat
balopat approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat merged commit 6b6196f into GoogleContainerTools:master May 4, 2020
@fmotrifork fmotrifork mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@briandealwis briandealwis Awaiting requested review from briandealwis

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skaffold Deploy using -i for images doesn't respect default repository
3 participants
@dgageot @balopat @googlebot