Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Explain how buildArgs are used by custom builder. #4077

Merged
merged 1 commit into from
May 3, 2020
Merged

[doc] Explain how buildArgs are used by custom builder. #4077

merged 1 commit into from
May 3, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 30, 2020

Fixes #3473

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #4077 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0.00%> (+2.43%) ⬆️

@dgageot
Copy link
Contributor Author

dgageot commented May 3, 2020

Self merging this doc change

@dgageot dgageot merged commit deede87 into GoogleContainerTools:master May 3, 2020
@fmotrifork fmotrifork mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat Awaiting requested review from balopat

@briandealwis briandealwis Awaiting requested review from briandealwis

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom-build-script-locally: ignores buildArgs
2 participants
@dgageot @googlebot