Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DEVELOPMENT.md on making changes to the skaffold api #4127

Merged
merged 1 commit into from
May 7, 2020
Merged

Update DEVELOPMENT.md on making changes to the skaffold api #4127

merged 1 commit into from
May 7, 2020

Conversation

gsquared94
Copy link
Contributor

Fixes: N/A

Description

Add a comment to the DEVELOPMENT.md
image

@codecov
Copy link

codecov bot commented May 7, 2020 •
edited
Loading

Codecov Report

Merging #4127 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️

briandealwis
briandealwis approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@briandealwis briandealwis added the kokoro:run runs the kokoro jobs on a PR label May 7, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 7, 2020
@balopat balopat merged commit 04b3bfe into GoogleContainerTools:master May 7, 2020
@gsquared94 gsquared94 deleted the update-dev-md branch May 7, 2020 21:57
@fmotrifork fmotrifork mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gsquared94 @briandealwis @balopat @googlebot @kokoro-team