Don’t duplicate the definition of portForward, under the profiles section.
#4165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `skaffold.yaml` reference documentation, under the `profiles` section, don’t duplicate the top-level definition of `portForward`. Signed-off-by: David Gageot <[email protected]>
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
Codecov Report
|
tejal29
added
the
docs-modifications
tejal29
reviewed
May 13, 2020
|
Please visit http://34.94.121.254:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
tejal29
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
skaffold.yamlreference documentation, under theprofilessection, don’t duplicate thetop-level definition of
portForward.Also make sure it's not going to break again in the future when we add top-level items.
Signed-off-by: David Gageot [email protected]