Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Values to artifactOverrides #4169

Merged
merged 5 commits into from
May 18, 2020
Merged

Rename Values to artifactOverrides #4169

merged 5 commits into from
May 18, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented May 13, 2020 •
edited
Loading

Fixes: #3316
Related: Relevant tracking issues, for context
Merge after: #4170

Description

In this PR,

  1. add a new field artifactOverrides
  2. Rename old fields values to artifactOverrides
  3. Make changes to skaffold fix to upgrade

User facing changes (remove if N/A)
No skaffold fix will print the new config.

tejaldesai@tejaldesai-macbookpro2 helm-deployment (deprecate_values)../../out/skaffold fix
apiVersion: skaffold/v2beta4
kind: Config
build:
  artifacts:
  - image: skaffold-helm
deploy:
  helm:
    releases:
    - name: skaffold-helm
      chartPath: charts
      artifactOverrides:
        image: skaffold-helm

@tejal29 tejal29 added the fixit label May 13, 2020
@tejal29 tejal29 mentioned this pull request May 13, 2020
Merged
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label May 13, 2020
@container-tools-bot
Copy link

Please visit http://34.94.51.192:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label May 13, 2020
@tejal29 tejal29 changed the title Deprecate Values and add new config field Rename Values to artifact May 14, 2020
@tejal29 tejal29 changed the title Rename Values to artifact Rename Values to artifactOverrides May 14, 2020
@codecov
Copy link

codecov bot commented May 14, 2020 •
edited
Loading

Codecov Report

Merging #4169 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/deploy/helm.go 79.12% <100.00%> (ø)
pkg/skaffold/schema/v2beta3/upgrade.go 100.00% <100.00%> (ø)

@tejal29
Copy link
Member Author

tejal29 commented May 14, 2020

Documentation on master
helm-maste

Vs New docs on branch
helm-branch

@balopat balopat merged commit a5a9d23 into GoogleContainerTools:master May 18, 2020
@fmotrifork fmotrifork mentioned this pull request May 20, 2020
Merged
@tete17 tete17 mentioned this pull request May 20, 2020
Merged
@tejal29 tejal29 deleted the deprecate_values branch April 15, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@briandealwis briandealwis Awaiting requested review from briandealwis

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes fixit size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm deployer: "values" cannot be used for anything except image names
4 participants
@tejal29 @container-tools-bot @balopat @googlebot