Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on LogAggregator’s Zero value #4199

Merged
merged 1 commit into from
May 18, 2020
Merged

Rely on LogAggregator’s Zero value #4199

merged 1 commit into from
May 18, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 16, 2020

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #4199 into master will decrease coverage by 0.08%.
The diff coverage is 75.00%.

Impacted Files Coverage Δ
pkg/skaffold/runner/build_deploy.go 57.89% <0.00%> (+0.60%) ⬆️
pkg/skaffold/runner/dev.go 66.41% <0.00%> (+0.50%) ⬆️
pkg/skaffold/kubernetes/log.go 34.14% <100.00%> (-4.80%) ⬇️
pkg/skaffold/runner/logger.go 37.50% <100.00%> (-62.50%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0.00%> (+2.43%) ⬆️

@balopat balopat merged commit 0550051 into GoogleContainerTools:master May 18, 2020
@fmotrifork fmotrifork mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@briandealwis briandealwis Awaiting requested review from briandealwis

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @balopat @googlebot