Add validations to Control API for Auto Triggers

[gsquared94]

Add validations to Control API for Auto Triggers

Related: #4145

Description
User facing changes (remove if N/A)

Return specific error codes with message

$ curl -X PUT http://localhost:50052/v1/build/auto_execute -d '{"enabled":false}' -i
HTTP/1.1 409 Conflict
Content-Type: application/json
Date: Fri, 29 May 2020 23:53:47 GMT
Content-Length: 47

{"error":"auto build is already set to false"}


$ curl -X PUT http://localhost:50052/v1/build/auto_execute -d '{"enable2d":false}' -i
HTTP/1.1 400 Bad Request
Content-Type: application/json
Date: Fri, 29 May 2020 23:54:40 GMT
Content-Length: 57

{"error":"missing required boolean parameter 'enabled'"}


$ curl -X PUT http://localhost:50052/v1/build/auto_execute -d '{"enabled":1}' -i
HTTP/1.1 400 Bad Request
Content-Type: application/json
Date: Fri, 29 May 2020 23:54:50 GMT
Content-Length: 69

{"error":"json: cannot unmarshal number into Go value of type bool"}

[codecov]

Codecov Report

Merging #4242 into master will increase coverage by 0.21%.
The diff coverage is 4.00%.

Impacted Files	Coverage Δ
pkg/skaffold/server/endpoints.go	0.00% <0.00%> (ø)
pkg/skaffold/server/server.go	48.88% <11.11%> (-4.77%)	⬇️
pkg/skaffold/kubernetes/watcher.go	87.50% <0.00%> (-12.50%)	⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go	63.41% <0.00%> (-4.88%)	⬇️
...ffold/kubernetes/portforward/resource_forwarder.go	84.31% <0.00%> (-3.45%)	⬇️
...g/skaffold/kubernetes/portforward/pod_forwarder.go	82.75% <0.00%> (-3.18%)	⬇️
pkg/skaffold/build/buildpacks/init.go	91.30% <0.00%> (-1.01%)	⬇️
pkg/skaffold/deploy/helm.go	79.83% <0.00%> (-0.41%)	⬇️
pkg/skaffold/schema/versions.go	82.75% <0.00%> (ø)
... and 15 more

[nkubala]

nice! this is pretty clean, and works well. my only comment is that in the CLI, i get errors that look like:

{"error":"auto build is already set to true","code":6,"message":"auto build is already set to true"}%

{"error":"json: cannot unmarshal bool into Go value of type map[string]json.RawMessage","code" :3,"message":"json: cannot unmarshal bool into Go value of type map[string]json.RawMessage"}%

could you remove the duplication of the error message to make it more readable?

[gsquared94]

nice! this is pretty clean, and works well. my only comment is that in the CLI, i get errors that look like:

{"error":"auto build is already set to true","code":6,"message":"auto build is already set to true"}%

{"error":"json: cannot unmarshal bool into Go value of type map[string]json.RawMessage","code" :3,"message":"json: cannot unmarshal bool into Go value of type map[string]json.RawMessage"}%

could you remove the duplication of the error message to make it more readable?

Done