Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default from resource name #4270

Merged
merged 2 commits into from
May 28, 2020
Merged

Remove default from resource name #4270

merged 2 commits into from
May 28, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented May 27, 2020 •
edited
Loading

Relates to #4223
Should merge before #4223

In this PR, do not print resource namespace if default.
Added tests.

@tejal29 tejal29 mentioned this pull request May 27, 2020
Merged
7 tasks
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #4270 into master will not change coverage.
The diff coverage is n/a.

@dgageot dgageot merged commit d531bff into GoogleContainerTools:master May 28, 2020
@fmotrifork fmotrifork mentioned this pull request Jun 12, 2020
Merged
@tejal29 tejal29 deleted the remove_default_name branch April 15, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgageot dgageot dgageot approved these changes

@balopat balopat Awaiting requested review from balopat

@briandealwis briandealwis Awaiting requested review from briandealwis

@nkubala nkubala Awaiting requested review from nkubala

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejal29 @dgageot @googlebot