Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor renames and change in the container status message. #4284

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Minor renames and change in the container status message. #4284

merged 2 commits into from
Jun 1, 2020

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Jun 1, 2020

While walking code with @balopat and testing scenarios, he suggested a change in the container status message reported.

Addressing that.

@tejal29 tejal29 requested a review from balopat June 1, 2020 19:34
@tejal29 tejal29 mentioned this pull request Jun 1, 2020
Merged
7 tasks
@codecov
Copy link

codecov bot commented Jun 1, 2020 •
edited
Loading

Codecov Report

Merging #4284 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/visitor.go 95.83% <100.00%> (+2.28%) ⬆️

@balopat balopat merged commit 5a9227c into GoogleContainerTools:master Jun 1, 2020
@fmotrifork fmotrifork mentioned this pull request Jun 12, 2020
Merged
@tejal29 tejal29 deleted the rename_func branch April 15, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@briandealwis briandealwis Awaiting requested review from briandealwis

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejal29 @balopat @googlebot