Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] add an example for global config #4341

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Jun 17, 2020

Fixes: #4305
A user reported from reading global config docs, it wasnt clear to create or add global config file.
Add a sample global config and specify this gets created when user runs skaffold config set

@tejal29
Copy link
Member Author

tejal29 commented Jun 17, 2020

Docs changes #4305 (comment)

@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Jun 17, 2020
@container-tools-bot
Copy link

Please visit http://35.236.7.240:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #4341 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4341      +/-   ##
==========================================
- Coverage   71.81%   71.78%   -0.03%     
==========================================
  Files         324      324              
  Lines       12476    12499      +23     
==========================================
+ Hits         8960     8973      +13     
- Misses       2948     2957       +9     
- Partials      568      569       +1     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/render.go 42.85% <0.00%> (-4.77%) ⬇️
cmd/skaffold/app/cmd/deploy.go 68.57% <0.00%> (-0.88%) ⬇️
pkg/skaffold/deploy/helm.go 78.13% <0.00%> (-0.75%) ⬇️
cmd/skaffold/app/cmd/flags.go 86.36% <0.00%> (ø)
pkg/skaffold/config/options.go 100.00% <0.00%> (ø)
pkg/skaffold/deploy/kustomize.go 77.71% <0.00%> (+0.13%) ⬆️
pkg/skaffold/deploy/kubectl.go 67.78% <0.00%> (+0.13%) ⬆️
pkg/skaffold/deploy/labels.go 55.95% <0.00%> (+1.07%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 63.41% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59fb6ff...9a8fac4. Read the comment docs.

@dgageot dgageot merged commit d32eec1 into GoogleContainerTools:master Jun 18, 2020
@tejal29 tejal29 deleted the fix_global_config_docs branch April 15, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Configuration
4 participants