Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add suggestion protos and hook up with Event API #4364

Merged
merged 3 commits into from
Jun 23, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Jun 20, 2020

Fixes #4331

Add Suggestion to event API.
In this PR,

  1. Add Suggestion to the ErrDef. Suggestion represent an action for a user to perform to recover from an error.
    Right now Suggestion includes:
    • SuggestionCode uniquely identifies a suggestion.
    • Action describes the action or step to recover.
      In future it can contain some metadata like if this message is kubernetes specific etc.

@tejal29 tejal29 requested a review from a team as a code owner June 20, 2020 00:39
@tejal29 tejal29 requested a review from tstromberg June 20, 2020 00:39
@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #4364 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4364      +/-   ##
==========================================
+ Coverage   71.74%   71.76%   +0.01%     
==========================================
  Files         324      324              
  Lines       12507    12532      +25     
==========================================
+ Hits         8973     8993      +20     
- Misses       2966     2969       +3     
- Partials      568      570       +2     
Impacted Files Coverage Δ
pkg/skaffold/errors/errors.go 81.48% <100.00%> (+5.29%) ⬆️
pkg/skaffold/event/event.go 90.86% <100.00%> (+0.27%) ⬆️
pkg/skaffold/debug/transform_nodejs.go 79.62% <0.00%> (-1.24%) ⬇️
pkg/skaffold/deploy/kubectl.go 67.10% <0.00%> (-0.68%) ⬇️
pkg/skaffold/deploy/kustomize.go 77.05% <0.00%> (-0.66%) ⬇️
pkg/skaffold/config/util.go 70.71% <0.00%> (-0.55%) ⬇️
pkg/skaffold/debug/debug.go 45.16% <0.00%> (ø)
pkg/skaffold/debug/transform.go 88.77% <0.00%> (ø)
pkg/skaffold/deploy/transformations.go 100.00% <0.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 63.41% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6033c8...5e1869d. Read the comment docs.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits but LGTM

proto/skaffold.proto Outdated Show resolved Hide resolved
proto/skaffold.proto Outdated Show resolved Hide resolved
@nkubala nkubala merged commit 93169dd into GoogleContainerTools:master Jun 23, 2020
@tejal29 tejal29 deleted the add_suggestion_protos branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new protos for suggestions or actionable error messages to Event API
3 participants