Move jib sync testdata to integration/examples
#4367
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4367 +/- ##
==========================================
- Coverage 71.78% 71.77% -0.02%
==========================================
Files 325 325
Lines 12594 12594
==========================================
- Hits 9041 9039 -2
- Misses 2978 2979 +1
- Partials 575 576 +1
Continue to review full report at Codecov.
|
| } | ||
| ``` | ||
|
|
||
| - You must include the `spring-boot-devtools` dependency at the `compile/implementation` scope, which is contrary to the configuration outlined in the [official docs](https://docs.spring.io/spring-boot/docs/current/reference/html/using-spring-boot.html#using-boot-devtools). Because jib is unaware of any special spring only configuration in your builds, we recommend using profiles to turn on or off devtools support in your jib container builds. |
There was a problem hiding this comment.
I think Jib currently includes spring-boot-devtools even if <optional>true. (And we decided to take care of this using an extension.) Should we still advise to set <scope>compile?
There was a problem hiding this comment.
I think we leave optional dependencies out. no?
There was a problem hiding this comment.
because it's not explicitly resolved to be a runtime dependency.
There was a problem hiding this comment.
oh about the scope, <compile> is default isn't it?
There was a problem hiding this comment.
Ah, right, compile is already the default. Then, the Spring Boot doc only adds <optional>true, so I think this comment to add it as compile doesn't apply.
And I think we include spring-boot-devtools regardless of <optional>true. (Would be good to double-check.)
There was a problem hiding this comment.
yeah you're right. I can say <!-- optional not necessary -->
loosebazooka
force-pushed
the
jib-sync-to-examples
branch
from
bcdd9aa
to
731843d
Compare
- separate out maven/gradle skaffold files into skaffold-maven.yaml and skaffold-gradle.yaml - add detailed README.md to example - does NOT copy example to in `/examples` yet
loosebazooka
force-pushed
the
jib-sync-to-examples
branch
from
849f023
to
8457c1e
Compare
and skaffold-gradle.yaml
/examplesyet