Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json output to skaffold schema list #4385

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 24, 2020

Fixes #4382

Signed-off-by: David Gageot [email protected]

@dgageot dgageot requested a review from a team as a code owner June 24, 2020 08:09
@dgageot dgageot requested a review from tstromberg June 24, 2020 08:09
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #4385 into master will increase coverage by 0.03%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4385      +/-   ##
==========================================
+ Coverage   71.73%   71.77%   +0.03%     
==========================================
  Files         325      325              
  Lines       12572    12594      +22     
==========================================
+ Hits         9019     9039      +20     
- Misses       2977     2979       +2     
  Partials      576      576              
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/schema/list.go 91.30% <95.23%> (-8.70%) ⬇️
cmd/skaffold/app/cmd/schema.go 82.60% <100.00%> (+2.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79f260...8030aab. Read the comment docs.

@dgageot dgageot merged commit 8f14d11 into GoogleContainerTools:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for --format json flag in skaffold schema list
4 participants