cmd: silence usage text #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #447 |
dgageot
suggested changes
Apr 24, 2018
cmd/skaffold/app/cmd/cmd.go
Outdated
| Short: "A tool that facilitates continuous development for Kubernetes applications.", | ||
| Use: "skaffold", | ||
| Short: "A tool that facilitates continuous development for Kubernetes applications.", | ||
| SilenceUsage: true, |
There was a problem hiding this comment.
If you move this line to PersistentPreRunE function, it will silent usage only after args are successfully checked.
There was a problem hiding this comment.
or use https://github.com/GoogleCloudPlatform/runtimes-common/tree/master/ctc_lib
Where we silenceUsage Errors in initializers.
|
@r2d4 Do you think you can update your PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supresses usage test from the output when we have an application error OR usage error. I can't find out a clear way to use cobra's arg validation and toggle this.
spf13/cobra#340
I'm a bit undecided about this. On one hand, we shouldn't output message error text on our application error, but on the other hand, for legitimate usage errors, the user needs to now run an additional
skaffold --help