Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log-tailing.md #4636

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Update log-tailing.md #4636

merged 2 commits into from
Aug 24, 2020

Conversation

schmurfy
Copy link
Contributor

@schmurfy schmurfy commented Aug 6, 2020

Description

Fixes a typo.

@schmurfy schmurfy requested a review from a team as a code owner August 6, 2020 06:36
@schmurfy schmurfy requested a review from tejal29 August 6, 2020 06:36
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@schmurfy
Copy link
Contributor Author

schmurfy commented Aug 6, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #4636 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4636      +/-   ##
==========================================
+ Coverage   73.15%   73.38%   +0.22%     
==========================================
  Files         337      341       +4     
  Lines       13294    13505     +211     
==========================================
+ Hits         9725     9910     +185     
- Misses       2958     2976      +18     
- Partials      611      619       +8     
Impacted Files Coverage Δ
pkg/skaffold/update/update.go 43.47% <0.00%> (-10.10%) ⬇️
cmd/skaffold/app/cmd/runner.go 73.17% <0.00%> (-5.78%) ⬇️
pkg/skaffold/runner/intent.go 74.19% <0.00%> (-5.12%) ⬇️
pkg/skaffold/build/gcb/docker.go 81.81% <0.00%> (-4.85%) ⬇️
pkg/skaffold/build/cache/hash.go 73.23% <0.00%> (-2.71%) ⬇️
pkg/skaffold/docker/image.go 73.36% <0.00%> (-2.64%) ⬇️
pkg/skaffold/build/local/docker.go 78.18% <0.00%> (-2.59%) ⬇️
pkg/skaffold/runner/runcontext/context.go 84.61% <0.00%> (-1.47%) ⬇️
pkg/skaffold/build/buildpacks/lifecycle.go 81.57% <0.00%> (-1.14%) ⬇️
pkg/diag/validator/pod.go 1.67% <0.00%> (-1.09%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0dfe2...372cb05. Read the comment docs.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@briandealwis
Copy link
Member

@blaggacao it doesn't appear that you've signed the CLA? Could you please visit https://cla.developers.google.com/ to sign?

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@briandealwis
Copy link
Member

The text was referencing the examples/microservices path with Skaffold, so I restored @schmurfy's fix and then fixed that up.

@briandealwis briandealwis merged commit f1086cc into GoogleContainerTools:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants