Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send update-check message to stderr #4655

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

briandealwis
Copy link
Member

Our new-version message is sent to stdout and so is mixed up with command output, as noted in #3582 (comment):

case msg := <-updateMsg:
fmt.Fprintf(cmd.OutOrStdout(), "%s\n", msg)

We should be sending the new-version message to stderr, just like our survey prompt:

if err := survey.New(opts.GlobalConfig).DisplaySurveyPrompt(cmd.OutOrStdout()); err != nil {
fmt.Fprintf(cmd.OutOrStderr(), "%v\n", err)

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #4655 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4655   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files         339      339           
  Lines       13320    13320           
=======================================
  Hits         9751     9751           
  Misses       2958     2958           
  Partials      611      611           
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 64.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a5c603...f470af1. Read the comment docs.

@briandealwis
Copy link
Member Author

Odd‚ the status is out of sync: although the pull request is reported as being Queued the actual Travis build succeeded.

@briandealwis briandealwis merged commit a33102f into GoogleContainerTools:master Aug 13, 2020
@briandealwis briandealwis deleted the ucstderr branch August 13, 2020 02:54
MrLuje pushed a commit to MrLuje/skaffold that referenced this pull request Aug 14, 2020
nkubala pushed a commit to nkubala/skaffold that referenced this pull request Aug 20, 2020
nkubala pushed a commit to nkubala/skaffold that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants