Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerfilePath in annotated-skaffold.yaml #467

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Fix dockerfilePath in annotated-skaffold.yaml #467

merged 1 commit into from
Apr 30, 2018

Conversation

oradwell
Copy link
Contributor

annotated-skaffold.yaml seems to be out of date. Issue #387 seems to be created because of it.

It took me a while to figure it out too since there isn't any other documentation around the dockerfilePath configuration.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@oradwell
Copy link
Contributor Author

oradwell commented Apr 25, 2018 via email

@oradwell
Copy link
Contributor Author

I signed it!

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We should figure out a better way to document this, since this might get out of date for the commented out fields (we do actually integration test this yaml)

@r2d4
Copy link
Contributor

r2d4 commented Apr 27, 2018

@oradwell Do you mind double checking the CLA? The bot hasn't seemed to register it. You'll need to make sure the commit author is set to the email you signed the CLA with.

@googlebot
Copy link

CLAs look good, thanks!

@oradwell
Copy link
Contributor Author

@r2d4 CLA was fine. I've re-committed the change which triggered the CLA check. thanks!

@dlorenc dlorenc merged commit 017912f into GoogleContainerTools:master Apr 30, 2018
@oradwell oradwell deleted the patch-1 branch May 1, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants