Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when skaffold config not found #4679

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Aug 17, 2020

before:

➜  skaffold dev
[skaffold.yaml] not found. You might need to run `skaffold init`

after:

➜  skaffold dev
skaffold config file skaffold.yaml not found - check your current working directory, or try running `skaffold init`

@nkubala nkubala requested a review from a team as a code owner August 17, 2020 17:54
@nkubala nkubala requested a review from gsquared94 August 17, 2020 17:54
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #4679 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4679   +/-   ##
=======================================
  Coverage   73.20%   73.21%           
=======================================
  Files         339      339           
  Lines       13322    13323    +1     
=======================================
+ Hits         9753     9754    +1     
  Misses       2958     2958           
  Partials      611      611           
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/runner.go 78.94% <100.00%> (ø)
pkg/skaffold/deploy/kustomize.go 77.84% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6994b45...cb61068. Read the comment docs.

@gsquared94 gsquared94 merged commit df141cd into GoogleContainerTools:master Aug 18, 2020
@nkubala nkubala deleted the better-error branch August 18, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants