Use ParseTolerant to parse Helm version because of missing patch version

[bdudelsack]

Fixes: #4711

Description

Use semVer ParseTolerant version to parse the Helm binary version because it does not follow all semver rules.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[bdudelsack]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[codecov]

Codecov Report

Merging #4712 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4712   +/-   ##
=======================================
  Coverage   73.38%   73.38%           
=======================================
  Files         341      341           
  Lines       13505    13505           
=======================================
  Hits         9910     9910           
  Misses       2976     2976           
  Partials      619      619           

Impacted Files	Coverage Δ
pkg/skaffold/deploy/helm.go	78.22% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4652950...bf016b2. Read the comment docs.

[briandealwis]

Thanks for the PR @bdudelsack. Could you please add a test around this? We don't seem to have just a explicit test of binVer(), but it seems like we should.

• add your v3.3 version to this set:

  skaffold/pkg/skaffold/deploy/helm_test.go

  Lines 346 to 353 in f7d1b6c

  	var (
  	// Output strings to emulate different versions of Helm
  	version20rc = `Client: &version.Version{SemVer:"v2.0.0-rc.1", GitCommit:"92be174acf51e60a33287fb7011f4571eaa5cb98", GitTreeState:"clean"}\nError: cannot connect to Tiller\n`
  	version21 = `Client: &version.Version{SemVer:"v2.15.1", GitCommit:"cf1de4f8ba70eded310918a8af3a96bfe8e7683b", GitTreeState:"clean"}\nServer: &version.Version{SemVer:"v2.16.1", GitCommit:"bbdfe5e7803a12bbdf97e94cd847859890cf4050", GitTreeState:"clean"}\n`
  	version30b = `version.BuildInfo{Version:"v3.0.0-beta.3", GitCommit:"5cb923eecbe80d1ad76399aee234717c11931d9a", GitTreeState:"clean", GoVersion:"go1.12.9"}`
  	version30 = `version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}`
  	version31 = `version.BuildInfo{Version:"v3.1.1", GitCommit:"afe70585407b420d0097d07b21c47dc511525ac8", GitTreeState:"clean", GoVersion:"go1.13.8"}`
  	)

• follow the example in other tests to override the DefaultExecCommand and use testutil.CmdRunWithOutput()

[bdudelsack]

Added the tests for helm v3.3.

The official binaries from helm do output the semver compliant version number, but custom built do not. For example Manjaro has a custom buit helm version in their repository which outputs not semver compliant version number.

[kudlatyamroth]

When we can expect release with this fix?

[briandealwis]

We're aiming to have a release on Wednesday. You can use the "bleeding edge" binaries — we typically cut our releases from HEAD.