Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop codecov patch threshold to 40% #4716

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Aug 24, 2020

this should help a bit with flakes

@nkubala nkubala requested a review from a team as a code owner August 24, 2020 19:55
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #4716 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4716      +/-   ##
==========================================
+ Coverage   73.34%   73.38%   +0.03%     
==========================================
  Files         338      341       +3     
  Lines       13394    13505     +111     
==========================================
+ Hits         9824     9910      +86     
- Misses       2962     2976      +14     
- Partials      608      619      +11     
Impacted Files Coverage Δ
pkg/skaffold/build/gcb/docker.go 81.81% <0.00%> (-4.85%) ⬇️
pkg/skaffold/deploy/kpt.go 85.32% <0.00%> (-3.09%) ⬇️
pkg/skaffold/build/cache/hash.go 73.23% <0.00%> (-2.71%) ⬇️
pkg/skaffold/build/local/docker.go 78.18% <0.00%> (-2.59%) ⬇️
pkg/skaffold/docker/image.go 73.36% <0.00%> (-1.86%) ⬇️
pkg/skaffold/runner/runcontext/context.go 84.61% <0.00%> (-1.47%) ⬇️
pkg/skaffold/build/buildpacks/lifecycle.go 81.57% <0.00%> (-1.14%) ⬇️
pkg/skaffold/docker/parse.go 89.94% <0.00%> (-0.43%) ⬇️
pkg/skaffold/config/options.go 100.00% <0.00%> (ø)
pkg/skaffold/runner/debugging.go 75.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 708519b...a4f4c80. Read the comment docs.

@briandealwis briandealwis merged commit fe0bb37 into GoogleContainerTools:master Aug 25, 2020
@nkubala nkubala deleted the codecov branch June 17, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants