Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change kpt deployer doc from Beta to Alpha #4728

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Change kpt deployer doc from Beta to Alpha #4728

merged 2 commits into from
Aug 28, 2020

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Aug 27, 2020

No description provided.

@yuwenma yuwenma requested a review from a team as a code owner August 27, 2020 21:13
@yuwenma yuwenma requested a review from nkubala August 27, 2020 21:13
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, you need to update this here: https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/schema/latest/config.go#L450

then run make generate-schemas and commit that.

@yuwenma
Copy link
Contributor Author

yuwenma commented Aug 27, 2020

actually, you need to update this here: master/pkg/skaffold/schema/latest/config.go#L450

then run make generate-schemas and commit that.

ah, skaffold generates the user reference from the schema comment. like it!

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #4728 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4728   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files         343      343           
  Lines       13585    13585           
=======================================
  Hits         9979     9979           
  Misses       2982     2982           
  Partials      624      624           
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abdbe17...4917f8c. Read the comment docs.

@nkubala nkubala merged commit 7d86254 into master Aug 28, 2020
@nkubala nkubala deleted the kpt-alpha branch August 28, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants