Surface error for render #4758
Merged
Surface error for render #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4758 +/- ##
=======================================
Coverage 73.70% 73.71%
=======================================
Files 345 345
Lines 13741 13743 +2
=======================================
+ Hits 10128 10130 +2
Misses 2981 2981
Partials 632 632
Continue to review full report at Codecov.
|
dgageot
suggested changes
Sep 3, 2020
nkubala
force-pushed
the
render-error
branch
from
a6a5baa
to
469a588
Compare
briandealwis
approved these changes
Sep 4, 2020
dgageot
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4726
this error was getting swallowed because the same buffer used to capture the templated manifests output by helm was also capturing stderr in the case of a failure, which was getting thrown away.