-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloud Shell for simpler Quickstart #4830
Conversation
Error creating deployment, please see controller logs for details. |
Error creating deployment, please see controller logs for details. |
Please visit http://35.236.72.108:1313 to view changes to the docs. |
Error creating deployment, please see controller logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #4830 +/- ##
==========================================
+ Coverage 71.72% 71.73% +0.01%
==========================================
Files 353 353
Lines 12099 12108 +9
==========================================
+ Hits 8678 8686 +8
- Misses 2775 2776 +1
Partials 646 646
Continue to review full report at Codecov.
|
I want to see if there's some better language for non-GCP customers to tell them how to create an account to use the Cloud Shell option. |
What kind of information do you think we should give to the user about this? Does the user have to do any setup on their account besides creating a google account? |
PTAL @MarlonGamez — added a note that it requires a Google Account and links to the signup page. |
Please visit http://34.94.181.12:1313 to view changes to the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fixes: #4813
Description
Adds an Open in Cloud Shell option to the Skaffold Quickstart. Required a minor reorganization to the page to flow better (IMHO).