fix: allow an environment variable to default the deploy namespace #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lets allow an environment variable to be used to define the helm deploy namespace fixes GoogleContainerTools#496
jstrachan
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
dgageot
suggested changes
May 5, 2018
| @@ -106,8 +107,12 @@ func (h *HelmDeployer) deployRelease(out io.Writer, r v1alpha2.HelmRelease, b *b | |||
| args = append(args, "upgrade", r.Name, r.ChartPath) | |||
| } | |||
|
|
|||
| if r.Namespace != "" { | |||
| args = append(args, "--namespace", r.Namespace) | |||
| ns := r.Namespace | |||
There was a problem hiding this comment.
Is there a way to map the cli arguments to env variables? I think there is. It would be much better to handle that once for all when CLI arguments are parsed.
There was a problem hiding this comment.
good point yeah; in this case we're merging default values from the CLI / env var overriding any missing values in the skaffold.yaml
dgageot
approved these changes
May 26, 2018
|
Let's merge this one and try to improve it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets allow an environment variable to be used to define the helm deploy namespace
fixes #496