Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix examples to appropriate type #4974

Merged
merged 2 commits into from
Oct 30, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/en/docs/references/yaml/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ function* template(definitions, parentDefinition, ref, ident, parent) {
yield html`
<tr>
<td>
<span class="key" style="margin-left: ${ident * 20}px">- <span class="${valueClass}">${v}</span></span>
<span class="key" style="margin-left: ${ident * 20}px">- <span class="${valueClass}">${JSON.stringify(v)}</span></span>
</td>
<td class="comment">#&nbsp;</td>
</tr>
Expand Down
2 changes: 1 addition & 1 deletion docs/content/en/schemas/v2beta9.json
Original file line number Diff line number Diff line change
Expand Up @@ -1659,7 +1659,7 @@
"x-intellij-html-description": "environment variables passed to the kaniko pod. It also accepts environment variables via the go template syntax.",
"default": "[]",
"examples": [
"{{name: \"key1\", value: \"value1\"}, {name: \"key2\", value: \"value2\"}, {name: \"key3\", value: \"'{{.ENV_VARIABLE}}'\"}\"}"
"[{\"name\": \"key1\", \"value\": \"value1\"}, {\"name\": \"key2\", \"value\": \"value2\"}, {\"name\": \"key3\", \"value\": \"'{{.ENV_VARIABLE}}'\"}]"
]
},
"force": {
Expand Down
2 changes: 1 addition & 1 deletion pkg/skaffold/schema/latest/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -1068,7 +1068,7 @@ type KanikoArtifact struct {

// Env are environment variables passed to the kaniko pod.
// It also accepts environment variables via the go template syntax.
// For example: `{{name: "key1", value: "value1"}, {name: "key2", value: "value2"}, {name: "key3", value: "'{{.ENV_VARIABLE}}'"}"}`.
// For example: `[{"name": "key1", "value": "value1"}, {"name": "key2", "value": "value2"}, {"name": "key3", "value": "'{{.ENV_VARIABLE}}'"}]`.
Env []v1.EnvVar `yaml:"env,omitempty"`

// Cache configures Kaniko caching. If a cache is specified, Kaniko will
Expand Down