fix: allow environment variables to be used in helm values #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes GoogleContainerTools#486 refactored this PR to reuse existing code for env templates
jstrachan
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
r2d4
approved these changes
Jun 21, 2018
There was a problem hiding this comment.
@jstrachan Thanks for the PR! Sorry it took so long to get this in. We're planning to have some of the image resolution moved to a per-project config file, but we just haven't had the time to implement it yet. Lets sync up as we start implementing it to make sure that its as easy as possible for JenkinsX to use that new feature.
We'll try to cut a release this week so you can start using it right away.
|
awesome thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #486
refactored this PR to reuse existing code for env templates