Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployers should only rely on their specific config #739

Merged
merged 1 commit into from
Jun 24, 2018
Merged

Deployers should only rely on their specific config #739

merged 1 commit into from
Jun 24, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 24, 2018

Signed-off-by: David Gageot [email protected]

r2d4
r2d4 approved these changes Jun 24, 2018
View reviewed changes
Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I think I was going to do this originally but I wasn't sure if we were going to put some generic metadata at the top level deploy config that it would need.

Looks like we don't need that.

@r2d4 r2d4 merged commit 2de144e into GoogleContainerTools:master Jun 24, 2018
@dgageot dgageot mentioned this pull request Jun 24, 2018
Merged
@dgageot dgageot deleted the deployer-config branch December 28, 2018 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r2d4 r2d4 r2d4 approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgageot @r2d4