Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small code changes #796

Merged
merged 1 commit into from
Jul 7, 2018
Merged

Small code changes #796

merged 1 commit into from
Jul 7, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 5, 2018

Here are changes I made in a PR that’s in progress.
I’d like to merge those improvements to the code
separately to make them easier to review.

Changes are mainly:

  • Making the order of Dockerfile/context arguments more the same
  • Support absolute paths to Dockerfiles
  • Reorganize the code that applies defaults to skaffold configs

Signed-off-by: David Gageot [email protected]

Here are changes I made in a PR that’s in progress.
I’d like to merge those improvements to the code
separately to make them easier to review.

Signed-off-by: David Gageot <[email protected]>
@r2d4 r2d4 merged commit a6b0b93 into GoogleContainerTools:master Jul 7, 2018
@dgageot dgageot deleted the refacto branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants