Fail if python script not found; run from any dir #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobcatfish
requested review from
dgageot,
dlorenc and
viglesiasce
as code owners
dgageot
approved these changes
Jul 18, 2018
If the script was run from anywhere other than the directory above hack, the python script could not be found, however since the error code was ignored, this would pass. Finding files and ignoring failed files was being done in one line. We wanted to ignore errors from grep, however this has the side effect of ignoring errors from the python script, e.g. if this script is run from an unexpected directory and the python script is not found. Lastly, filtering of dirs was being done in both `boilerplate.sh` and `boilerplate.py` so now it will just be done in `boilerplate.sh`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
boilerplate.shwas run from anywhere other than the directory abovehack,the python script could not be found, however since the error code was
ignored, this would pass.
Finding files and ignoring failed files was being done in one line. We
wanted to ignore errors from grep, however this has the side effect of
ignoring errors from the python script, e.g. if this script is run
from an unexpected directory and the python script is not found.
Lastly, filtering of dirs was being done in both
boilerplate.shandboilerplate.pyso now it will just be done inboilerplate.sh.