Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t tag the same images twice #842

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Don’t tag the same images twice #842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/skaffold/build/local.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ type LocalBuilder struct {
localCluster bool
pushImages bool
kubeContext string

alreadyTagged map[string]string
}

// NewLocalBuilder returns an new instance of a LocalBuilder
Expand Down Expand Up @@ -126,6 +128,13 @@ func (l *LocalBuilder) buildArtifact(ctx context.Context, out io.Writer, tagger
return "", fmt.Errorf("digest not found")
}

if l.alreadyTagged == nil {
l.alreadyTagged = make(map[string]string)
}
if tag, present := l.alreadyTagged[digest]; present {
return tag, nil
}

tag, err := tagger.GenerateFullyQualifiedImageName(artifact.Workspace, &tag.Options{
ImageName: artifact.ImageName,
Digest: digest,
Expand All @@ -144,5 +153,7 @@ func (l *LocalBuilder) buildArtifact(ctx context.Context, out io.Writer, tagger
}
}

l.alreadyTagged[digest] = tag

return tag, nil
}