Get namespace for updating objects from build artifact #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deploying with helm to a non-default namespace, we were seeing the warning "error adding label to runtime object". This was because accessor.GetNamespace() always returned an empty string rather than the specified namespace. It seems the original object doesn't have the namespace field specified. To fix this problem, we can access the namespace from the build artifact instead of the accessor. Should fix GoogleContainerTools#899
priyawadhwa
changed the title
r2d4
approved these changes
Sep 4, 2018
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
=======================================
Coverage 43.28% 43.28%
=======================================
Files 63 63
Lines 2629 2629
=======================================
Hits 1138 1138
Misses 1372 1372
Partials 119 119
Continue to review full report at Codecov.
|
|
The kaniko test on kokoro is failing because it's unable to push images (has been happening all morning since GCR is experiencing outages) I'll try running it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying with helm to a non-default namespace, we were seeing the warning "error adding label
to runtime object". This was because accessor.GetNamespace() always
returned an empty string rather than the specified namespace. It seems
the original object returned by helm doesn't have the namespace field specified.
To fix this problem, we can access the namespace from the build artifact
instead of the accessor.
Should fix #899