Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web config file not loaded when is relative path #636

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

monkeyWie
Copy link
Member

related: #605

@monkeyWie monkeyWie added the bug Something isn't working label Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 60.95%. Comparing base (7ca1cc8) to head (3bb3496).

Files Patch % Lines
cmd/server.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
- Coverage   62.25%   60.95%   -1.30%     
==========================================
  Files          35       35              
  Lines        3518     3537      +19     
==========================================
- Hits         2190     2156      -34     
- Misses       1053     1114      +61     
+ Partials      275      267       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monkeyWie monkeyWie merged commit f89fb5e into main Aug 9, 2024
2 of 4 checks passed
@monkeyWie monkeyWie deleted the fix/web_config_file branch August 9, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant