Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid HTTP zero connections #729

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Conversation

monkeyWie
Copy link
Member

No description provided.

@monkeyWie monkeyWie added the bug Something isn't working label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.50%. Comparing base (5124413) to head (d095cb7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocol/http/fetcher.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
+ Coverage   61.48%   61.50%   +0.02%     
==========================================
  Files          35       35              
  Lines        3609     3611       +2     
==========================================
+ Hits         2219     2221       +2     
+ Misses       1117     1115       -2     
- Partials      273      275       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monkeyWie monkeyWie merged commit a198132 into main Sep 7, 2024
3 of 4 checks passed
@monkeyWie monkeyWie deleted the fix/http_zero_connections branch September 7, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant