Fix borders not always toggling back when exiting preview. Fixes #2637 #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esJS#2637 As described by [this issue](GrapesJS#2637), the component borders may not be toggled back when exiting preview mode in some cases. This fixes this issue by adding a `shouldRunSwVisibility` flag to the Preview command, set via the Commands API on its run (before stopping the `sw-visibility` command if it's active), & used on stop to reactivate the `sw-visibility` command if needed. Which also implies: - Prevent toggling of component borders while preview is active - Rely on the Commands API to detect if the `sw-visibility` command is active rather than a panel button - Prevent resetting the `shouldRunVisibility` flag on multiple subsequent (forced) runs / stops of the preview command
mcottret
changed the title
artf
approved these changes
Apr 1, 2020
|
Awesome @mcottret thank you very much ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by this issue, the component borders may not be toggled back when exiting preview mode in some cases.
This fixes this issue by adding a
shouldRunSwVisibilityflag to the Preview command, set via the Commands API on its run (before stopping thesw-visibilitycommand if it's active), & used on stop to reactivate thesw-visibilitycommand if needed.Which also implies:
sw-visibilitycommand is active rather than a panel buttonshouldRunVisibilityflag on multiple subsequent (forced) runs / stops of the preview command