option to not cap slider value to max #3147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @artf I hope you are doing well.
I noticed something in the style manager, if you set a property as a slider and the element that is rendered has a calculated style value (e.g margin-top) greater than the slider max, the integer input appended to the slider also gets capped to the slider max instead of showing the real calculated value in the input.
I've added two attributes to bypass this behavior called limitlessMax and limitlessMin, let me know if you think there's better name for it.
In my custom repo i added this attribute to the margins and paddings properties, but i did not want to mess with the style property factory in the pull request.
Let me know what you think,
Kind regards,
Juan