Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to not cap slider value to max #3147

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

jcamejo
Copy link
Contributor

@jcamejo jcamejo commented Nov 20, 2020

Hi @artf I hope you are doing well.

I noticed something in the style manager, if you set a property as a slider and the element that is rendered has a calculated style value (e.g margin-top) greater than the slider max, the integer input appended to the slider also gets capped to the slider max instead of showing the real calculated value in the input.

I've added two attributes to bypass this behavior called limitlessMax and limitlessMin, let me know if you think there's better name for it.

In my custom repo i added this attribute to the margins and paddings properties, but i did not want to mess with the style property factory in the pull request.

Let me know what you think,

Kind regards,

Juan

@artf
Copy link
Member

artf commented Nov 25, 2020

Hi Juan, sounds good to me 👍

In my custom repo i added this attribute to the margins and paddings properties, but i did not want to mess with the style property factory in the pull request.

You did right :)

@artf artf merged commit d802eba into GrapesJS:dev Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants