Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sorter usage in StyleManager #6123

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fix Sorter usage in StyleManager #6123

merged 2 commits into from
Sep 5, 2024

Conversation

mohamedsalem401
Copy link
Member

@mohamedsalem401 mohamedsalem401 commented Sep 4, 2024 •
edited
Loading

For #6122
Merging this PR is for a temporary fix for the bug as we will refactor the Sorter soon

  • The model in the style manager doesn't have the .components() method. Instead, we should check if it's a collection and get the length from there.

@mohamedsalem401 mohamedsalem401 requested review from artf and removed request for artf September 4, 2024 19:01
artf
artf approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@artf artf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you @mohamedsalem401

@mohamedsalem401 mohamedsalem401 merged commit 211f17a into dev Sep 5, 2024
1 check passed
@mohamedsalem401 mohamedsalem401 deleted the fix-sorter branch September 5, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artf artf artf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohamedsalem401 @artf