Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove extra build #6127

Merged
merged 2 commits into from
Sep 8, 2024
Merged

refactor: remove extra build #6127

merged 2 commits into from
Sep 8, 2024

Conversation

danstarns
Copy link
Member

We have an extra build step in the CI we don't need, and --force is not needed either.

artf
artf approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@artf artf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

One thing I'd recommend to check if we're still running ts:build, which generates TS files, and ts:check which ensures the generated file is valid (sometimes it's happened the TS file had some issues)

@danstarns danstarns merged commit a063d6f into dev Sep 8, 2024
1 check passed
@danstarns danstarns mentioned this pull request Sep 8, 2024
Merged
@danstarns
Copy link
Member Author

👍

One thing I'd recommend to check if we're still running ts:build, which generates TS files, and ts:check which ensures the generated file is valid (sometimes it's happened the TS file had some issues)

#6133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artf artf artf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danstarns @artf