feat: add DataSources to project json storage #6160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artf
requested changes
Sep 22, 2024
…s into feat/datasource-storage
artf
approved these changes
Sep 24, 2024
Comment on lines
+196
to
+200
| ### Benefits of Using `skipFromStorage` | ||
|
|
||
| 1. **Persistent Configuration**: Store configuration data that should persist across project saves and loads. | ||
| 2. **Default Data**: Include default data that should always be available in the project. | ||
| 3. **Selective Storage**: Choose which DataSources to include in the project JSON, optimizing storage and load times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to store DataSources in the project JSON, allowing for persistent data across project saves and loads. Key additions include the
skipFromStorageflag and updated store and load methods in the DataSourceManager.