Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node panics shouldn't bring down the editor #1552

Closed
Tracked by #144
Keavon opened this issue Jan 7, 2024 · 2 comments · Fixed by #1846
Closed
Tracked by #144

Node panics shouldn't bring down the editor #1552

Keavon opened this issue Jan 7, 2024 · 2 comments · Fixed by #1846
Assignees
@TrueDoctor
Labels
Architecture Involves architecture or engineering work or discussion Feature New feature or request Graphene Involves the node graph system/engine used by Graphite Rust Involves Rust programming for the backend
Milestone
Milestone 39

Comments

@Keavon
Copy link
Member

Keavon commented Jan 7, 2024 •
edited
Loading

Sandbox various components, like the node graph, in panic handlers. Reload those components instead of having to reload the whole page. Avoid making the document get lost since that's highly destructive to the user and almost always shouldn't be corrupted by whatever bug resulted in the crash, so the document data should most likely be in tact.

Some options:

  • Move the graph evaluator into a web worker?
  • Something with panic handlers?
  • Reboot the node graph executor somehow?
@Keavon Keavon added Feature New feature or request Rust Involves Rust programming for the backend Paper Cut A small UX annoyance we should strive to improve Graphene Involves the node graph system/engine used by Graphite labels Jan 7, 2024
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Jan 7, 2024
@0HyperCube 0HyperCube mentioned this issue Jan 13, 2024
Closed
@Keavon Keavon added Architecture Involves architecture or engineering work or discussion and removed Paper Cut A small UX annoyance we should strive to improve labels Jan 14, 2024
@Keavon Keavon changed the title Make node panics not bring down the editor Node panics shouldn't bring down the editor Jun 9, 2024
@TrueDoctor TrueDoctor moved this from Short-Term to In-Progress Tasks in Task Board Jul 24, 2024
@TrueDoctor
Copy link
Member

@Keavon should we close this or remove it from the in progress tasks?

@Keavon Keavon mentioned this issue Aug 4, 2024
Merged
@Keavon
Copy link
Member Author

Keavon commented Aug 4, 2024

Closed by #1846

@Keavon Keavon closed this as completed Aug 4, 2024
@github-project-automation github-project-automation bot moved this from In-Progress Tasks to Tasks Completed This Sprint in Task Board Aug 4, 2024
@Keavon Keavon added this to the Sprint 39 milestone Aug 4, 2024
@Keavon Keavon mentioned this issue Aug 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TrueDoctor TrueDoctor

Labels
Architecture Involves architecture or engineering work or discussion Feature New feature or request Graphene Involves the node graph system/engine used by Graphite Rust Involves Rust programming for the backend
Projects
Task Board
Archived in project
Milestone
Milestone 39
2 participants
@Keavon @TrueDoctor