Sandbox node graph execution on native targets and attempt recovery from panics on Wasm #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueDoctor
force-pushed
the
sandbox_nodegraph
branch
from
b0ed8c7 to
bf00d89
Compare
|
Note to test this you can enable the vello feature which currently just calls a panic, this will of course need to be removed before merging |
Keavon
force-pushed
the
master
branch
11 times, most recently
from
fceb3a6 to
ab87486
Compare
TrueDoctor
changed the title
TrueDoctor
force-pushed
the
sandbox_nodegraph
branch
from
c4fff68 to
9bdcbb6
Compare
TrueDoctor
force-pushed
the
sandbox_nodegraph
branch
from
74e3e36 to
56f1a30
Compare
Keavon
changed the title
Keavon
force-pushed
the
sandbox_nodegraph
branch
from
56f1a30 to
9c2c3b0
Compare
Keavon
force-pushed
the
sandbox_nodegraph
branch
from
9c2c3b0 to
6f2cda1
Compare
Keavon
force-pushed
the
sandbox_nodegraph
branch
from
6f2cda1 to
6e498bb
Compare
Keavon
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1552
This implements panic catching for native targets using the rust std
catch_unwindfunction. As this does not work on wasm yet: rust-lang/rust#118168, I've implemented a hacky workaround which should give the user the ability to still save their work when the editor crashes and recover some of their work