Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draggable upstream nodes feature #1812

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Add draggable upstream nodes feature #1812

merged 7 commits into from
Jul 9, 2024

Conversation

adamgerhant
Copy link
Collaborator

Adds the ability to automatically drag upstream nodes. Fixes bug when deselecting a node with shift+click.

@adamgerhant adamgerhant marked this pull request as ready for review July 7, 2024 17:57
@Keavon Keavon changed the title Drag upstream nodes Add draggable upstream nodes feature Jul 8, 2024
@Keavon
Copy link
Member

Keavon commented Jul 8, 2024

Can you please adjust this to ignore layer bottom inputs? Dragging a layer should only move it and its left inputs, not those below it.

@adamgerhant
Copy link
Collaborator Author

I made the change, but wouldn’t that mostly be done by the layer/stack locking. I thought this was useful because if there are a bunch of overlapping layers you can drag and first layer and all layers below it would also move.

@Keavon
Copy link
Member

Keavon commented Jul 8, 2024

Can you also please make it de-conflict the amplified movement that we currently get when a node/layer is selected while another upstream node/layer is also selected?

capture.mp4

@Keavon Keavon enabled auto-merge (squash) July 9, 2024 12:06
@Keavon Keavon merged commit f4e3e5a into master Jul 9, 2024
2 checks passed
@Keavon Keavon deleted the lock-organization branch July 9, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants