Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw-rs: use camera white balance when available #1941

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

elbertronnie
Copy link
Collaborator

@elbertronnie elbertronnie commented Aug 19, 2024

Depends on #1923

  • Add White Balance Tag
  • Move scale colors steps above raw to image step
  • Merge raw to image step and demosaicing step
  • Use white balance from camera in scale colors step

Copy link

github-actions bot commented Sep 1, 2024

Performance Benchmark Results


compile_demo_art::compile_group::iai_compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 59,921,970 (master) -> 27,972,470 (HEAD) : $$\color{lime}-53.32\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     468,858|    442,040          -5.72%
D1mw                     170,231|    147,758         -13.20%
DLmr                      55,595|     53,935          -2.99%
DLmw                      96,515|     96,405          -0.11%
Dr                    14,058,263|  6,608,355         -52.99%
Dw                    10,275,969|  4,814,640         -53.15%
EstimatedCycles       92,084,128| 46,460,441         -49.55%
I1mr                     165,345|     41,876         -74.67%
ILmr                       1,563|        936         -40.12%
Ir                    59,921,970| 27,972,470         -53.32%
L1hits                83,451,768| 38,763,791         -53.55%
LLhits                   650,761|    480,398         -26.18%
RamHits                  153,673|    151,276          -1.56%
TotalRW               84,256,202| 39,395,465         -53.24%

compile_demo_art::compile_group::iai_compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 25,051,932 (master) -> 12,424,558 (HEAD) : $$\color{lime}-50.40\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     200,247|    190,141          -5.05%
D1mw                      70,827|     61,749         -12.82%
DLmr                       1,629|      1,280         -21.42%
DLmw                      11,172|     10,748          -3.80%
Dr                     5,874,492|  2,934,936         -50.04%
Dw                     4,244,523|  2,120,555         -50.04%
EstimatedCycles       36,947,081| 18,945,571         -48.72%
I1mr                      66,227|     17,808         -73.11%
ILmr                       1,430|        863         -39.65%
Ir                    25,051,932| 12,424,558         -50.40%
L1hits                34,833,646| 17,210,351         -50.59%
LLhits                   323,070|    256,807         -20.51%
RamHits                   14,231|     12,891          -9.42%
TotalRW               35,170,947| 17,480,049         -50.30%

compile_demo_art::compile_group::iai_compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 7,027,690 (master) -> 3,128,939 (HEAD) : $$\color{lime}-55.48\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      42,401|     39,450          -6.96%
D1mw                      24,852|     22,376          -9.96%
DLmr                           1|          1          +0.00%
DLmw                       3,546|      3,513          -0.93%
Dr                     1,772,326|    858,391         -51.57%
Dw                     1,372,734|    703,729         -48.74%
EstimatedCycles       10,626,512|  5,067,271         -52.31%
I1mr                      19,465|      5,752         -70.45%
ILmr                          16|         16          +0.00%
Ir                     7,027,690|  3,128,939         -55.48%
L1hits                10,086,032|  4,623,481         -54.16%
LLhits                    83,155|     64,048         -22.98%
RamHits                    3,563|      3,530          -0.93%
TotalRW               10,172,750|  4,691,059         -53.89%

compile_demo_art::compile_group::iai_compile_to_proto with_setup_3:load_from_name(red-dress)
Instructions: 69,867,762 (master) -> 33,627,257 (HEAD) : $$\color{lime}-51.87\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     574,311|    541,644          -5.69%
D1mw                     209,874|    183,314         -12.66%
DLmr                      78,121|     75,638          -3.18%
DLmw                     110,760|    110,369          -0.35%
Dr                    16,411,959|  7,916,434         -51.76%
Dw                    11,994,581|  5,776,853         -51.84%
EstimatedCycles      107,925,684| 56,024,810         -48.09%
I1mr                     200,278|     48,796         -75.64%
ILmr                       1,570|        968         -38.34%
Ir                    69,867,762| 33,627,257         -51.87%
L1hits                97,289,839| 46,546,790         -52.16%
LLhits                   794,012|    586,779         -26.10%
RamHits                  190,451|    186,975          -1.83%
TotalRW               98,274,302| 47,320,544         -51.85%

compile_demo_art::compile_group::iai_compile_to_proto with_setup_4:load_from_name(valley-of-spires)
Instructions: 49,143,536 (master) -> 21,653,757 (HEAD) : $$\color{lime}-55.94\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     370,711|    352,657          -4.87%
D1mw                     144,538|    126,348         -12.58%
DLmr                      32,458|     30,718          -5.36%
DLmw                      58,264|     57,747          -0.89%
Dr                    11,480,052|  5,110,595         -55.48%
Dw                     8,407,902|  3,724,255         -55.71%
EstimatedCycles       74,394,872| 35,216,433         -52.66%
I1mr                     134,014|     32,879         -75.47%
ILmr                       1,489|        878         -41.03%
Ir                    49,143,536| 21,653,757         -55.94%
L1hits                68,382,227| 29,976,723         -56.16%
LLhits                   557,052|    422,541         -24.15%
RamHits                   92,211|     89,343          -3.11%
TotalRW               69,031,490| 30,488,607         -55.83%

@elbertronnie elbertronnie merged commit 82ef5c8 into master Sep 2, 2024
4 checks passed
@elbertronnie elbertronnie deleted the use-camera-white-balance-in-raw-rs branch September 2, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants